[Tim Roberts]

so what is the best way to update this plugin? do i deinstall and then reinstall?

[Tim Roberts]

and I must correct the issue now, but when do you think you will have an update that eliminates this bug?

[Steven Zahm]

@ Tim

This is a bug with the two custom fields not Connections. It is a quick simple fix, may I install the WP Editor plugin?

[Tim Roberts]

yes, please install and then let me know what the problem was. where did we go wrong? i greatly appreciate the help. i am also interested in knowing how to update the plugin safely in the future. thank you, Steve.

[Steven Zahm]

@ Tim

I’ve fixed it.

These lines in class.entry.php

return $this->newsarchives;
return $this->additionalresearch;

need to be:
return $this->format->sanitizeString( $this->newsarchives, TRUE );
return $this->format->sanitizeString( $this->additionalresearch, TRUE );

Now, the remaining problem … all the links that were entered in these fields need fixed, manually.

The data is saved in the databased escaped on purpose for security puposes using the $wpdb->prepare() function. I created helper functions for the text fields that automatically strip slashes amoungst other processes.

Now, updating. That going to be problematic. You have two options that I see. Pull a copy of the updated Connections and have you dev migrate the changes. Or, update to the latest version, have the dev create the custom fields by using the supported functions/methods and then re-input the info. Neither seem like much fun!

[Tim Roberts]

So here is the 64K question…

If I use the latest version that allows for custom fields, do I need to worry about this? I see it this way:

1. Back up the data
2. Update the plugin to the latest version.
3. Create the new custom fields using the latest version.
4. Migrate the old info to the new version.
5. Update normally thereafter.

Does this seem like a feasible plan? If so, I can update everything on my dev server and move over the new clean files after the fact. Let me know if this makes sense. and whether or not it will work. Also, can you tell me how long it took you to fix this? Just an estimated time? I want to keep my developer honest. Thanks.

[Steven Zahm]

@ Tim

The actually change only took me a minute but the total time was about 2 hours mainly due to figuring out the where and the changes were made and replying back to the forum. After I knew where the code changes were and after I put a test link in each of the four fields in a test entry, the issue became immediately apparent to me and what the fix would be.

Hope that helps!

[Author]

Posts