404 gives error in class.seo.php

Hi again

I went back to Twenty Fifteen theme with all the plugins deactivated. I have also done diffs for the plugins with the master versions and found no differences.

All I can think of is that Wordfence Security of Simple Firewall have made changes to system files (outside of plugins and the theme) to improve security but to break Connections. i.e. if those plugins are deactivated I’m assuming they can still make changes in other places? I’m not sure. I just can’t think of what else it could be.

I feel the only way forward now is to create a blank WordPress installation on the same host, and slowly add everything back in, one step at a time. i.e. install a plugin. Copy one setting across at a time, while testing for the issue. Then put each page and post back one at a time. It is hugely laborious but I don’t see another way to track this down. I can eventually then do a recursive diff between all the files to see if it was a file issue, if all the files are functionally the same then it would mean the database had become corrupted somehow.

Thanks.

I know this isn’t exactly the same issue, however the response below is maybe a clue. The person says that the OP’s query might not have returned a WP_Post object. So even though your filter callback gets called at the correct times, maybe $wp_query contains a query that didn’t return any results OR it doesn’t contain the WP_Post object as we’ve already said.

From (https://wordpress.stackexchange.com/questions/60297/wp-query-queried-object-id-throws-warning-undefined-property)

$wp_query->queried_object->ID has several potential points of failure:

Your query may not be dealing with a WP_Post object. The queried_object can also reference a taxonomy in some circumstances.
Your query may not have actually identified any results. Your queried_object could be null, and thus you’re asking for a property on an nonexistent object.
You could be using $wp_query in code that does not have a reference to that global. If you determine that $wp_query itself is null, you should add

global $wp_query;
… somewhere above your code.

========================

p.s. if I try and italicise a variable like $with_underscore in these posts I get $with_underscore and not $nounderscore.

The following is an improved version of the function. Using global variables is bad practise in any coding environment. WordPress is poorly designed as it seems to encourage the use of global variables. I have removed two global variables below and used member function calls instead. This gets rid of the bug and makes the code more robust. I have tested Connections, regular pages and posts, and also 404’s. Everything works.

/**
 * Add the the current Connections directory location/query to the page title.
 *
 * NOTE: $id really isn't optional, some plugins fail to use the `the_title` filter correctly,
 * ie. "Display Posts Shortcode", causes Connections to crash an burn if not supplied.
 *
 * @access private
 * @since  0.7.8
 * @static
 *
 * @uses   get_query_var()
 *
 * @param  string $title The browser tab/window title.
 * @param  int    $id    The page/post ID.
 *
 * @return string
 */
public static function filterPostTitle( $title, $id = 0 ) {
    global /*$wp_query, $post,*/ $connections;

  // Added by MY on 22nd October 2015.
  // Return the existing title if the current page is not found.
  if ( is_404() ) return $title;

  // Whether or not to filter the page title with the current directory location.
  if ( ! cnSettingsAPI::get( 'connections', 'connections_seo', 'page_title' ) ) return $title;

  // Added by MY on 22nd October 2015.
  // Get the post ID.
  $post_id = get_queried_object_id();

  //if ( ! is_object( $post ) || $wp_query->post->ID != $id || ! self::$filterPermalink ) return $title;
  if ( $post_id != $id || ! self::$filterPermalink ) return $title;

Thanks for your patience so far Steven. I can see your point about working with many developers. I also feel WordPress development is messy… it is a fantastic platform but it feels like it’s been hacked form early version of code rather than designed from the ground up. I guess we have to work with what we have… a great platform… that’s a bit hacky at times. As developers it makes it hard to do things the ‘right way’. Your compromises are sound.

Apologies for missing your var_dump() comment. That was a good call.

Here are the results of the var_dumps() you requested:

404

• $page (undefined causing an error)
• $wp_query->post = NULL

Known page [not a Connections page – let me know if you want that]

• $page (undefined causing an error)
• $wp_query->post = [SEE BELOW]

object(WP_Post)#2773 (24) {
      ["ID"]=>
      int(225)
      ["post_author"]=>
      string(1) "2"
      ["post_date"]=>
      string(19) "2015-09-25 15:56:23"
      ["post_date_gmt"]=>
      string(19) "2015-09-25 14:56:23"
      ["post_content"]=>
      string(1939) "Contents of page were here

 "
      ["post_title"]=>
      string(31) "Find Rented Property"
      ["post_excerpt"]=>
      string(0) ""
      ["post_status"]=>
      string(7) "publish"
      ["comment_status"]=>
      string(6) "closed"
      ["ping_status"]=>
      string(6) "closed"
      ["post_password"]=>
      string(0) ""
      ["post_name"]=>
      string(31) "find-rented-property"
      ["to_ping"]=>
      string(0) ""
      ["pinged"]=>
      string(0) ""
      ["post_modified"]=>
      string(19) "2015-10-05 20:46:48"
      ["post_modified_gmt"]=>
      string(19) "2015-10-05 19:46:48"
      ["post_content_filtered"]=>
      string(0) ""
      ["post_parent"]=>
      int(0)
      ["guid"]=>
      string(44) "http://www.example.com/?page_id=225"
      ["menu_order"]=>
      int(0)
      ["post_type"]=>
      string(4) "page"
      ["post_mime_type"]=>
      string(0) ""
      ["comment_count"]=>
      string(1) "0"
      ["filter"]=>
      string(3) "raw"
    }