404 gives error in class.seo.php

The problem with the code:

if ( ! is_object( $post ) || $wp_query->post->ID != $id || ! self::$filterPermalink ) return $title;

is that you check for $post NOT being an object THEN you access $wp_query->post->ID.

However if $post is an object but $wp_query->post is not set then $wp_query->post->ID will fail, because your $post check is no protection against the illegal access.

This is safer and more sensible:

if ( ! set( $wp_query->post->ID ) || $wp_query->post->ID != $id || ! self::$filterPermalink ) return $title;

The problem only ever seems to occur for a 404 anyway, so the is_404() check like we said is another double check.

The final response on my StackOverflow question relating to this issue was:

Unfortunately, I’m still not sure what that check is actually there
for. $post should be an object during the_title filter, no matter if a
post is returned or a 404 is shown (so is_object( $post ) seems
redundant)…$wp_query should be NULL if you’re on a 404 page, since
there’s no actual query object. Otherwise, I have no idea when
$wp_query->post->ID wouldn’t be equal to the $id passed to the filter.
Honestly, I’d remove that check in favor of using if (
!get_queried_object() ) return $title;