Reply To: Logos not displaying

06/30/2015 at 4:40 pm #339164
Steven Zahm
Keymaster

@ Traci

I decided to reply to you in this thread instead of the email so this info is public…

I did determine that the issue was definitely being cause by the ProPhoto theme. It has a content filter that modifies the markup for images. Connections uses the new HTML5 markup for the img tag. Specifically the srcset attribute to support Hi HiDPI (Retina) images. It seems their parser can not correctly deal with that markup (best guess) and corrupts the img tag output used by Connections… the result no images being shown.

The fix fortunately was simple. They wisely choose to check the images class and if the image has the img-as-is that img would be skipped. Since I wisely :) included a filter in Connections to add classes to the image and logo I could easily add a new filter to add the img-as-is class. With this filter added, the logos display. I have included this filter in the compatibility file within Connections so all future updates will apply this fix if the ProPhoto theme is being used. Basically this means to you, the fix is update safe.

If you have a moment, I would truly appreciate a review they really do make a difference. Many thanks in advance!

https://wordpress.org/support/view/plugin-reviews/connections